elementary icon indicating copy to clipboard operation
elementary copied to clipboard

Add disablement flag for uploading test results

Open Maayan-s opened this issue 3 years ago • 1 comments

The test results upload happens on an on-run-end. Users should have a way to disable it in a specific run using a var.

Maayan-s avatar Sep 04 '22 21:09 Maayan-s

+1 There should be a way to temporarily disable elementary on-run-start and on-run-end hook using a var.

For example by modifying dbt_project.yml (thats our current hack):

on-run-start:
  - "{%- if var('use_elementary', default=false) -%} {{ elementary.create_elementary_tests_schema() if flags.WHICH in ['test', 'build'] }} {%- endif -%}"
on-run-end:
  - "{%- if var('use_elementary', default=false) -%} {{ elementary.handle_tests_results(results) if flags.WHICH in ['test', 'build'] }} {%- endif -%}"
  - "{%- if var('use_elementary', default=false) -%} {{ elementary.upload_run_results(results) }} {%- endif -%}"

jakubvedral avatar Sep 08 '22 13:09 jakubvedral

Introduced a var called disable_tests_results.

elongl avatar Nov 29 '22 09:11 elongl

Is there anything like this that would be model-specific? For instance if we wanted not to upload particularly wide models from uploading the test_results_query, would this be possible for said models?

DakotaMichael avatar Jul 09 '24 20:07 DakotaMichael

Hi @DakotaMichael, could you perhaps elaborate a bit on the use-case or the problem you're trying to solve? Thanks.

elongl avatar Jul 10 '24 08:07 elongl