Elliot Tower
Elliot Tower
The tests all passed on the different Mac versions (11, 12, and 13 with m1) so I think it must be something on your end
We could add a note for required Linux libraries like that, can you give me a list of which ones in particular you did not have? Our GitHub Actions scripts...
Also run the pre-commit hooks as that will give you some feedback about docstrings adhering to the right format.
> Looks fairly sensible so far, seems like these are just files taken from SS with docstrings added. For type hinting, I would recommend something like [the way Gymnasium does...
Jets pr got merged which was an example of doubt SuperSuit style wrappers, you should try to follow it as an example
I'd have to read this through in more details to properly understand it but my first thought is that I know Gymnasium handles certain errors in their envs in testing...
I’m not a big fan of using _local_vars, I think we should do however Gymnasium wrappers are done with inheriting attributes and such, to ensure consistency between the two packages....
https://github.com/Farama-Foundation/Gymnasium/blob/c57f6d82219f35250b7cdd1b0c871687f9ea4e70/gymnasium/wrappers/common.py#L229 Looks like everything is done based off env.property instead of defining new properties (don’t do self.action space = self.env.action space for example)
Appreciate the help guys, will take a look and try to get these things merged as soon as possible.
Thanks for asking, there's a number of ones I'm aware of at least--there are surely more options out there. I can see it being a bit confusing how the tutorials...