Elliot Tower
Elliot Tower
Hi @dm-ackerman any chance you could submit the PR for this? Or if you are too busy could you describe what you did to fix this?
Ok awesome, appreciate it:)
These environments have had some pretty serious design flaws for a long time and are basically only kept around because people find them useful for benchmarking, I could see potentially...
It would but I’m not an expert on the envs so can’t comment much on it, would have to talk with Ben Black or Jordan or someone else for confirmation....
It may be good to mention somewhere in the tutorials the LRU caching thing and then link to an environment which uses it, but yeah I agree having it in...
> @elliottower I may have to take a different approach to this actually. Tests are failing because the space object have to return the exact same object. Ah right yeah...
Interesting commit messages hahah looks good though, the LRU cache I guess is not necessary for the api test to pass here? May still be worth mentioning the situations in...
Your call on how to handle the lru caching stuff, I honestly don't know too much about which parts of the environment are the bottlenecks, my guess is this is...
> Actually, I'm indifferent about leaving it in the error message. I think having the function return the same object in the error message is sufficient. The lru cache idea...
> I think the error message about returning the exact same object is reasonable. That's a pretty basic OOP concept. Fair enough, I was just thinking in terms of like,...