Elliott Brooks

Results 150 comments of Elliott Brooks

The service worker was added to speed things up, so there will be an IPL hit in trying to bypass it. However, I think the issue described in https://github.com/flutter/devtools/issues/3896#issuecomment-1422711019 might...

Thank you! Opened up https://dart-review.googlesource.com/c/sdk/+/286100 to use `Cache-Control: no-store` for now. This should help us identify if the caching issues are coming from the HTTP cache or the service worker....

Marking this as fixed, we can re-open if more caching issues resurface in the future.

Closing as duplicate of https://github.com/dart-lang/webdev/issues/1874

@annagrin @nshahan any idea what the difference here is between dynamically loading a script with DDC vs dart2js?

Thank you! Looking. Does a flaky tests automatically get disabled in Flutter, or should I open a PR to skip the test for now while trying to identify the root...

SG, opened https://github.com/flutter/flutter/pull/124257 for disabling only

Some notes while investigating. Initially I though this might be around the work around hot-restart and breakpoints (https://github.com/flutter/devtools/issues/7231) but none of the packages that were touched for that work changed...

Possibly related: Flutter integration tests have been flaking for hot restart/reload as well: https://github.com/flutter/flutter/issues/146879

I increased the `pumpDuration` after hot-restart, and got a bit further in the test. The actual failure (I believe) is the more menu dialog is either not properly opening, or...