Paweł Poławski
Paweł Poławski
@KKoukiou I think this is a merge candidate :)
@kraxel @osteffenrh - following latest EDK2 development guidelines, instead of mailing list I have created PR here for the easier review and discussion :)
I can eventually copy over keycodes I am using but it may not be the "cleanest" solution to this problem. Yet it would satisfy the CI.
What if I will just copy needed definitions directly into the driver code / header? It would solve the issue but eventually in the future we could go out of...
I missed the fact that GH closed this PR and I cant overwrite this. I have addressed review comments and opened new PR: https://github.com/tianocore/edk2/pull/6444 @kraxel @osteffenrh @leiflindholm
> One concern I'd have is that allowing any string allows passing in strings that will break the XML; perhaps we should either escape the value in an attribute context...
@supakeen I have updated the code to add regexp validation of this parameter - still not sure if I did it correct. @mvo5 tests has been added but one is...
Hi @mvo5 - I have updated this PR to the latest version. Right now I do not have a capacity to extend the tests. Shall we keep this PR open...
@mvo5 feel free to take over this PR content and cherry pick any useful pieces :)
Looks like this need to be rebased manually on top of latest changes.