anaconda icon indicating copy to clipboard operation
anaconda copied to clipboard

util: Add additional information for EFI systems

Open jcpunk opened this issue 1 year ago • 8 comments

Backport partition information from https://github.com/rhinstaller/anaconda/pull/5765

jcpunk avatar Aug 06 '24 21:08 jcpunk

Yes, we need a ticket, since the script is included in the RHEL installation environment. I've created the ticket: https://issues.redhat.com/browse/RHEL-55129

@jcpunk please update the commit message and add a line: Resolves: RHEL-55129 That should be enough from your side. Thanks.

jstodola avatar Aug 19 '24 15:08 jstodola

Added

jcpunk avatar Aug 19 '24 16:08 jcpunk

/kickstart-test --testtype smoke

elkoniu avatar Oct 07 '24 10:10 elkoniu

For some reason the JIRA ticket got assigned to me... since I don't work at RH I find that odd. Figured I'd note it here in case that is blocking things.

jcpunk avatar Oct 16 '24 15:10 jcpunk

For some reason the JIRA ticket got assigned to me... since I don't work at RH I find that odd. Figured I'd note it here in case that is blocking things.

Oops sorry for the noise. Feel free to ignore.

KKoukiou avatar Oct 16 '24 15:10 KKoukiou

@KKoukiou I think this is a merge candidate :)

elkoniu avatar Oct 16 '24 20:10 elkoniu

For some reason the JIRA ticket got assigned to me... since I don't work at RH I find that odd. Figured I'd note it here in case that is blocking things.

We want to first cover it with kickstart tests, this is the task that you will be working on as we agreed :)

KKoukiou avatar Oct 17 '24 06:10 KKoukiou

I'm not sure how I'd test this with kickstart since it is a tool for user's to capture logs and system state when things go wrong.

jcpunk avatar Oct 17 '24 16:10 jcpunk

From what I've looked at breifly, I'd suggest running /usr/libexec/anaconda/log-capture in %post --nochroot of the kstest and checking the stderr if it is expected (ideally empty but that needs some fix first). To see if the tooling we call is available on the image.

Maybe it would be good to add this to some existing suitable test if there is some (I doubt so). Or we could create a new one for such cases, like tools.

If you want I can take care of it.

rvykydal avatar Oct 23 '24 07:10 rvykydal

Fixes should get forwardported to Fedora or maybe resolved there first.

jkonecny12 avatar Oct 23 '24 08:10 jkonecny12