Ellis Kenyő
Ellis Kenyő
@tarsius This has been confirmed to be resolved either by doom or magit; so all's well in the end. Apologies this was left hanging for so long
Try master now @vicecaycedo @jrock2004 @zeitchef
> @elken any updates on this? it'd be really nice to have this fixed Posted an update on discord but for visibility; I'm leaving the company that uses flutter so...
> I've tried running this branch with the latest master changes, and here's an error I get when opening a dart buffer, and also when I call `lsp-dart-run` in my...
Thanks for this ping, I really do hate having a life sometimes :sweat_smile: This weekend I should be free so I'll try my very best to pick it up. I...
> @elken Feel free to do whatever it's easiest for you, I can migrate it later, there are some missing points on other places of lsp-dart that I still need...
@ericdallo I can't apologise enough for this taking so long :sweat_smile: I've fixed both the issues I mentioned in the original message, so this should be fine to look over...
> Thank you very much for this @elken! I reviewed and manually tested and works great, I will merge this and do only a few refactorings on master like removing...
I can try to verify it & merge it at some soon yeah
> Is this ready to merge? Looks like there's some merge conflicts to resolve too but yeah it can be > There are a couple small issues, mainly to do...