Eli Grey

Results 81 comments of Eli Grey

> Could you explain what exactly the current implementation breaks? That is, which Consent Managers does the current implementation break, and what is broken? Transcend Consent Manager heeds GPC &...

Yeah, I can open up a PR later today or tomorrow 👍. I'll request your review once it's up

@ghostwords here's a PR for you to check out: https://github.com/EFForg/privacybadger/pull/2790

@svnhub Yes, this is the airgap.js based system. Our customer logo wall primarily represents Privacy Center customers. Instead of providing you with a list of customers that use our consent...

I have plenty of `.xhtml` documents that prettier started doing this to recently. Here's an example XHTML document that was affected (src redacted): ```xhtml ```

> We only lowercase doctype when it's HTML5. The HTML5 doctype is not exclusive to the `text/html` content type. You should only apply this lowercasing to `text/html`, `*.html`, `*.htm`, etc....

Before I can find a spec reference for you, I emplore you to create an .xhtml file locally and test this for yourself in any web browser.

[Here's the relevant standard](https://www.w3.org/TR/xml/#NT-doctypedecl:~:text=Physical%20Structures.-,Document%20Type%20Definition,%27%3C!DOCTYPE%27,-S%20Name%20\() which shows that XML requires an all-capital DOCTYPE.

I haven't read the spec, but possibly it doesn't support multibyte characters. To encode a string to a bytestring in JavaScript, you need to do `unescape(encodeURIComponent(data))`. Likewise, to decode it,...