Elia Schito
Elia Schito
No worries, thanks for reviewing and merging!
@tvdeyen I see the point, the current implementation is based purely on the existing VC implementation that includes them by default. That said, as a counterpoint, I would offer that...
@tvdeyen I was referring to this https://github.com/ViewComponent/view_component/blob/main/lib/view_component/base.rb#L477-L481. Routes along with some helpers[1] are included in the base, the only reason we initially went with separate routes helpers was to mimic...
@tvdeyen it's quite simply less overhead and noise, i.e. removing the redundancy of typing `solidus_admin.` from within components inheriting from `SolidusAdmin::BaseComponent`.
I'm putting this on hold until we figure out a few things on how it will be used in the new admin dashboard.
> I like the general idea of cleaning things up, but have some questions: @tvdeyen thanks for the question, happy to clarify the proposal 🙌 > * Are we using...
@coorasse I think this might be fixed by the release of `solidus_stripe` v5, which features and uses a conversion utility module: https://github.com/solidusio/solidus_stripe/blob/be652e65b3f9d892c9e462bf7cda0dbcb0f8f6a0/lib/solidus_stripe/money_to_stripe_amount_converter.rb
@andreaforni any updates on this, can be closed until your pull request? /cc @mcollina @andreareginato
@andreaforni ho creato un branch su [rubydayit/conference_site](https://github.com/rubydayit/conference_site/tree/collaboration-page), si chiama `collaboration-page` puoi fare push direttamente lì, e poi appena c'è qualcosa puoi fare una pull in cui continuiamo la conversazione :)
@andreaforni fatto il commit a tuo nome ;P