Elia Schito

Results 181 comments of Elia Schito

@jtapia I mentioned the PR title, but the most important thing is the commit message, for future lookups, as the current one could be confusing 🙏

@aldesantis 💯 The tricky part about that is supporting older versions, so maybe we could resurrect solidus_cmd for that purpose, moving it to thor and leaving out the extension generation…...

We should add some options to the command I thinks, like: `--skip-assets` or `--skip-frontend-assets`, those should work for both the updates and the extension generation.

@cpfergus1 I rebased this on top of https://github.com/solidusio/solidus_dev_support/pull/188, since they were touching similar files, once that's merged we can rebase on master and merge it if everything checks.

@RyanofWoods I'm ok with merging this, but wondering if it can be set on your machine level `.gitignore` instead 🤔

@basicfeatures would you be able to provide the basic steps (need for it to be fancy!) you used to move manually from root to a namespace? That could turn very...

Ouch, I re-read the docs and found that is the declared behavior :) Consider this a feature request instead

I think in the past that's what happened most of the time. With ActionText available in Rails 6+ would probably make sense to integrate that when available. Would you be...

@memotoro good call! I added an issue (https://github.com/solidusio-contrib/solidus_editor/issues/48) to add action-text to solidus_editor 👍

The only issue I know about was with the custom require system from rspec-support. It's vendored to let people use a different version in CRuby world. That said probably @adambeynon...