Elia Schito

Results 181 comments of Elia Schito

@schneems to add context to the stacktrace above we're seeing this in production, the server in our case is [Rainbows!](http://rainbows.bogomips.org) with `ThreadPool` strategy which is indeed multithreaded. This is a...

Not a super big set, but `foo.js` has _132_ dependecies, so I think it's a fair benchmark ``` p setup_env[Sprockets::CachedEnvironment].find_asset('foo').metadata[:dependencies].size # => 132 ``` (the _control_ benchmark is there just...

It's all self contained, you can save the script to something like `/tmp/bench.rb` and just run it. :)

Hey @tmgemedia I tried creating a failing test that gets solved by this PR but couldn't, can you please provide some code that brakes the formatter?

@davidwessman that's awesome! I just checked it out and it works perfectly ๐Ÿ™Œ I think for now we can have a thin layer [removing](https://github.com/nebulab/erb-formatter/blob/7afe8f2f324808d1c4131ae81f5667360364f0c1/lib/erb/formatter.rb#L81) and [re-adding](https://github.com/nebulab/erb-formatter/blob/7afe8f2f324808d1c4131ae81f5667360364f0c1/lib/erb/formatter.rb#L342) the front matter whenever...

Oh good call, I guess we should have some generic way to tell it to ignore the contents of a block or tag ๐Ÿค”

I think this is a bit harder and at the moment I don't have the time it would require, but happy to review a PR if you wanna take up...

> Is the gem check only looking in the Gemfile? Sorry for the delay ๐Ÿ™ It's not, the way it checks for presence in the Gemfile is by running `bundle...

> Oh I understand now: the formatter was just erroring because of incorrect tags. Is there a way to have VS Code highlight these issues in the editor? I would...

> Not sure if the formatter uses `terminal.integrated`, but maybe there is another profile? The extension [is simply using `execSync`](https://github.com/nebulab/erb-formatter-vscode/blob/main/erb-formatter.js#L19-L22) it generates the updated code and uses [the editor api...