Markus Elfring
Markus Elfring
:crystal_ball: Do you need any configuration checks for incompliant tools (by the software build system)?
:crystal_ball: In which time range do you plan to work more with smart pointers?
:thought_balloon: Smart pointers can also help to get rid of redundant pointer checks, can't they?
:eyes: See also [a related change idea](https://gitlab.xiph.org/xiph/rnnoise/-/issues/8 "Completion of error handling").
:thought_balloon: Would you like to take [the C++ guideline “R.11: Avoid calling new and delete explicitly”](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#r11-avoid-calling-new-and-delete-explicitly "Recommendations around allocation and deallocation") better into account?
>… - oh did you mean something like `#include "xxx-test.c"`? Yes. — If you would insist to keep such source code there at all for example.
I suggest to apply another software refactoring before questionable code will be preserved at inappropriate places.
[Example](https://refactoring.com/catalog/ "Catalog of refactorings"): Under which circumstances will a bit of source code be moved into another file?
I propose to extract mentioned test cases earlier.
:thought_balloon: Probably, yes.