Markus Elfring

Results 555 comments of Markus Elfring

>It's not necessary to delete these action objects `mClearSeparator`, `mClearAction` and `mEmptyAction` because their parent object is RecentFileMenu. I suggest to take another look at [these implementation details](https://github.com/pencil2d/pencil/blob/9adb6170edccb608896b03fb8869a6d62a4bf261/core_lib/src/interface/recentfilemenu.cpp#L25 "Constructor for...

>In Pencil2D or any Qt application, a resource handle is the parent object. How does this information fit to a statement [like “`uiOptionsBox = new Ui::ImportImageSeqOptions;`”](https://github.com/pencil2d/pencil/blob/90e7164349d8d542bc2e96a546716ac5d9156883/app/src/importimageseqdialog.cpp#L35 "Update candidate: ImportImageSeqDialog class")?

Would you eventually prefer to use another parent parameter for these objects instead?

>If we can I would love to, but we can't. Will another look at implementation details become helpful? >Those `UI::XXX` files are auto-generated by a Qt's codegen tool called `uic`....

>…, however I do not think you have brought up anything significant yet. :crystal_ball: Some C++ programmers can find the reduction of explicit delete operator calls helpful, can't they?

>Is this what you are asking? * Partly, yes. I got the impression that another UI file is not used for the mentioned dialogue (while UI files are provided for...

>Use `_exit()` instead? This could be one possibility. Would you like to consider other software design options? - [sigwaitinfo()](http://pubs.opengroup.org/onlinepubs/9699919799/functions/sigwaitinfo.html) - [Self-pipe trick](http://cr.yp.to/docs/selfpipe.html) - [Signal-safe locks](https://locklessinc.com/articles/signalsafe_locks/)

I would prefer to clarify acceptable software design directions before contributing patches in a source code format.

The proposed alternatives are already illustrated by other information sources. Would you like to become more familiar with the choices?

I suggest to avoid [ignorance of return values](https://cwe.mitre.org/data/definitions/252.html) a bit more. Are you interested to apply [aspect-oriented software development](http://aspectc.org/)? How do you think about to encapsulate error detection and corresponding...