Christian Eltzschig

Results 85 comments of Christian Eltzschig

@eboasson This was also raised as an issue in iceoryx, here are some thoughts from our side. From a first look everything seems to be in order in our code...

@elBoberido @eboasson > There was this PR eclipse-iceoryx/iceoryx#1357 which fixed it for all scenarios we could reproduce. Actually, this PR prepared everything to fix this issue but in the end...

@sgf201 I would see it as a cyclonedds issue first and when this reveals problems in iceoryx I would start investigating this problem on the iceoryx side.

@mossmaurice I think your structure goes in the right direction but is to fine grained. I would merge `queues` and `containers`. If both would contain more than 10 classes than...

@elBoberido @mossmaurice @elfenpiff Agreed on the following final structure: ``` ./iceoryx_hoofs ./iceoryx_hoofs/legacy ./iceoryx_hoofs/legacy/include ./iceoryx_hoofs/legacy/include/iceoryx_hoofs ./iceoryx_hoofs/legacy/include/iceoryx_hoofs/cxx ./iceoryx_hoofs/legacy/include/iceoryx_hoofs/cxx/vector.hpp ./iceoryx_hoofs/container ./iceoryx_hoofs/container/source ./iceoryx_hoofs/container/source/vector.cpp ./iceoryx_hoofs/container/include ./iceoryx_hoofs/container/include/iox ./iceoryx_hoofs/container/include/iox/vector.hpp ./iceoryx_hoofs/container/include/iox/detail ./iceoryx_hoofs/container/include/iox/detail/vector.inl ./iceoryx_hoofs/container/unittests ./iceoryx_hoofs/integrationtests ``` * the folder...

@mossmaurice @elBoberido @MatthiasKillat @FerdinandSpitzschnueffler sorry but I reopened it. Please correct me if I am wrong but a relative pointer: * is a low level abstraction for a C pointer...

> > The public API of the optional comparision operators has changed. Please add this to `doc/website/release-notes/iceoryx-unreleased.md` as refactoring item and an additional migration path for users at the end...

@elBoberido but I fear that we won't use the latest gtest upstream version anytime soon. I would still add the extra comma when after the change the code compiles without...

I think upgrading to 1.11 or 1.12 could become a huge task. You know gtest deprecated `TYPED_TEST_CASES` and we use them excessively for testing generic types. I have no idea...

@elBoberido then lets go for it. I created an issue: https://github.com/eclipse-iceoryx/iceoryx/issues/1663