Evan Lezar
Evan Lezar
@klihub I simplified this PR a bit to start with. If you're ok with the general direction, we can get this in and then move some of the other functionalty...
@bart0sh @klihub sorry for the delay here. I have pulled the validation specifics into #247.
As an example, I have created https://github.com/NVIDIA/nvidia-container-toolkit/pull/872 to provide an example of the usage of the new API.
> One of the tests is failing now (TestCacheWriteSpec/multiple_spec_files/data,_some_invalid). Yes. I have updated the implementation. The `DefaultValidator` was not checking for non-null `Devices`.
Is there a reason to know the complete set? Looking at the linked issue, it seems as if only certain GPUs are supported. Are there other properties -- such as...
@mrunalp @tianon any comments here?
Thanks @kad. Do we have an indidation as to when the merged commit will be released as an OCI Runtime Spec version bump?
@kannon92 we need to bump the dependencies and (optionally) move from the deprecated APIs. The containerd PR should be similar enough to be used as a guideline.
Kubernetes doesn't depend on the spec at all. It should only be forwarding the cdi device names as opaque strings. There is some logic around constructing the container annotations (if...
@kannon92 I think k8s would want to consume the v0.8.0 package / spec since this removes the dependency on the OCI runtime specification.