Evan Lezar
Evan Lezar
> The code LGTM for what you're intending to do. However, I'll have to lean on @giuseppe , @haircommander and @saschagrunert on the safeness of swapping out the runtime like...
> The unit test failures may be legit. Can we also add a test to https://github.com/cri-o/cri-o/blob/main/test/reload_config.bats, maybe by injecting a fake runtime? OK. I will have a look.
@saschagrunert I have updated the unit tests and also added some tests as suggested. I don't have my development environment quite set up, so I've been resting on the CI...
> would you still consider this to be a draft @elezar ? @haircommander no, I don't think so. I just wanted to get the tests looking in a better shape....
I have rebased the changes here and updated the status. What are the best docs for getting a development environment set up? Ideally this would be containerized.
/test integration_rhel
@haircommander we could start out with only allowing new runtimes and then see what the implications are w.r.t. removing existing ones (although that is strictly speaking also a use case...
I have created #6056 as a first pass.
I was on PTO and didn't have a chance to look at #6056. I will pick it up again.
> I suppose we should add a test... Yes, that would be great as well as documentation for the addition to the spec.