Eldad Rudich comments

Repositories
Issues
Comments

Results 4 comments of


                                            Eldad Rudich

ksniff graceful shutdown on Ctrl+C + Wireshark doesn't close on exit

Hi @aviramha - sorry for the delay, had a rough time.. I'll review your code today, thank you so much for this contribution!

ksniff graceful shutdown on Ctrl+C + Wireshark doesn't close on exit

Thanks, did you push the new code? I don't see new commits

ksniff graceful shutdown on Ctrl+C + Wireshark doesn't close on exit

It seems the windows build is broken `pkg/cmd/sniff.go:356:4: unknown field 'Setpgid' in struct literal of type syscall.SysProcAttr pkg/cmd/sniff.go:357:4: unknown field 'Pgid' in struct literal of type syscall.SysProcAttr Makefile:26: recipe for...

ksniff graceful shutdown on Ctrl+C + Wireshark doesn't close on exit

Hi @aviramha, sorry again for the late response... In this case, I believe the cleaner approach is to extract the process execution code to its own struct and hide the...