eldadcool
eldadcool
Your patch has a bug regarding the message length calculation. You need to perform the len function on the msg.data and not data. because data is a padded buffer with...
Sure, I will create a pull request as soon as I will have time to work on it
> looks like `__pydantic_generic_metadata__` has the info > > ```py > from typing import * > from pydantic import * > T1 = TypeVar('T1') > class ABCModel(BaseModel, Generic[T1]): > f1:...
> Thanks for the fix! I guess that a test should also be added, using a pattern similar to https://github.com/secdev/scapy/blob/master/test/scapy/layers/x509.uts#L53 I tried to add a test but encounter a few...
test was added and rebased on the updated master
> I'll try to take a look over the next couple of days. @eldadcool do you happen to have a link to the patch set in the kernel? @lumagi, sure:...
> I'm not sure whether I can really review the patch, as I'm not that familiar with Pythons packing concept. But if you strictly followed the data structure and the...
> Yes, this is intentional. > The idea is that the content which is sent via virtual CAN devices is not extensively sanitized to be able to test with uncertain...
> ping @eldadcool Hii sorry, I was not very available last month... Added replies to your comments. :)