Elad Salomons comments

Results 35 comments of


                                            Elad Salomons

Position valves

And in this example, `ko=0.19` corresponds to a fully opened valve. Such examples should go into the documentation.

Fix pressure breaking valve: valve will generate head instead losing, when the flow is negative

I must say I have never used a PBV. @makusuko, can you elaborate on the use case?

Modeling Pump Group Hydraulics

@LRossman just so I understand the problem with @samhatchett suggestion, the syntax of his suggestion could work but then the APIs can't support it since they just take the link's...

Modeling Pump Group Hydraulics

How about merging it into a separate branch and keep thinking about it for a while? A lot of was put in this by @lepton1979

Rewrite the API functions to be id and not index based

Wouldn't this slow down setting and retrieving data as the index would need to be found each function call?

Rewrite the API functions to be id and not index based

We can keep this open but bump it to v2.3.

Rewrite the API functions to be id and not index based

Moving to 2.3

binary report file dot-extension

Yes, we should agree on the extensions. EPANET uses 4 [files](https://github.com/OpenWaterAnalytics/EPANET/wiki/File-Descriptions): input (INP), report, output and hydraulic. What I have seen and used are .rpt for report, .out for the...

Allow null-terminated strings as element IDs

could be done but might be important to do it in a way which won't break old code (backward compatibility). Also, 128 characters would defiantly break compatibility with EPANET 2.0...

Allow null-terminated strings as element IDs

Moving to 2.3