Elad Salomons

Results 35 comments of Elad Salomons

Thank you, @LRossman. Do you think the change in the results for `wolf-3.inp` is neglectable? https://ci.appveyor.com/project/OpenWaterAnalytics/epanet/build/job/7xmdv31fm4bncsxt#L321 For reference, here is the paper by Olivier Piller et al. [14753.pdf](https://github.com/OpenWaterAnalytics/EPANET/files/9259318/14753.pdf)

This will have to wait a bit until we can read the demand categories names (#290). I think that we would like to save zero demands for demand categories unless...

So you will add a new property for a rule\control, like `active`?

I totally agree. @LRossman can you just explain what you mean by the `OFFLINE` cases? It is when the tank is closed?

We got a little closer today with #89 for the `[RULES]` section.

We don't have the vertices yet, what else is missing? This can go to 2.3.

Should we keep this issue open for future enhancement?

@Mariosmsk I was actually referring to the `[TAGS]` section, see here: https://epanet22.readthedocs.io/en/latest/input_keywords.html