Ewoud Kohl van Wijngaarden

Results 1159 comments of Ewoud Kohl van Wijngaarden

Oh, good point. They really are "constants" because they're not frozen.

That should still be there. Perhaps another case of [environment isolation](https://www.puppet.com/docs/puppet/8/environment_isolation.html) problems?

For Ruby I ended up implementing a [composite action](https://docs.github.com/en/actions/sharing-automations/creating-actions/creating-a-composite-action): https://github.com/voxpupuli/ruby-release. This works because a composite action doesn't create a new context and you can generate an OIDC token.

@jherrman I think the rebase on master failed. Do you need help with that?

Test failure looks related: ``` [MinitestRetry] retry 'test_: AnsibleRolesController::GET #index should render template index. ' count: 1, msg: ActionController::MissingExactTemplate: AnsibleRolesController#index is missing a template for request formats: text/html ``` Other...

Would it be better to do a version 8.n+1 which emits a deprecation warning?

> I'm unclear how best to test this. In https://github.com/theforeman/foreman/pull/10605#pullrequestreview-3009592626 I described where we provide parameters. Then it runs through the snapshots and is validated. In that PR I already...

Oh that's annoying. Perhaps you can fake it and use `host_param().respond_to?(:join)` to determine if it's an array.

Let me phrase it different: I'd like to minimize our mock configs. Perhaps even split it so we can layer them, just like in real life. So a config for...

@evgeni what do we do with this?