Eran Kampf

Results 20 comments of Eran Kampf

IMHO I think `graphql-server-core` should be that place for shared code between integrations. An even more radical idea I'm contemplating with is to actually move all integrations *into* `graphql-server-core` (under...

hey @uebayasi , do `_get_graphql_params` starts with this code: ``` try: request_data = self.request.json_body if isinstance(request_data, basestring): request_data = dict(query=request_data) except: request_data = {} ``` Meaning, if you send a...

In requests.py there's this code: ``` def _json_body__get(self): """Access the body of the request as JSON""" return json.loads(self.body.decode(self.charset)) def _json_body__set(self, value): self.body = json.dumps(value, separators=(',', ':')).encode(self.charset) def _json_body__del(self): del self.body...

This is part of the webob 1.2.3 library that webapp2 depends on

@vinayski @hamzamohdzubair are you guys using GAE? is this library even relevant anymore?

Hey @mrrobby So basically Graphiql is a static React website - a bunch of html, js, css resources that you need to serve from some protcted path. Basically if you...

@syrusakbary sounds like I'll be bale to add a `GraphiqlHandler` to the library on the `next` branch...

@svpino I would copy the Flask code in @syrusakbary mentioned above: https://github.com/graphql-python/flask-graphql/blob/master/flask_graphql/render_graphiql.py

I actually disagree with disallowing asserts. The asserts are not here to test anything that might actually happen in runtime, and should be fun to be removed in production environment...

@dsanders11 if you create a schema dynamically you still shouldn't reach most of the cases I see in your PR. Like create a Connection type with Meta definition? Call `NodeField`...