Elizabeth Paul
Elizabeth Paul
Hi Richard, Thanks for putting together this PR. A few comments: - At the moment, Lconstraint = -2 allows one to both a) impose the normal field in a 1...
> Hi Elizabeth, > > > At the moment, Lconstraint = -2 allows one to both a) impose the normal field in a 1 volume calculation and 2) use the...
> Would this be motivation enough to introduce another input variable for the case when the normal BC is non-zero? I would be ok either way. Does anyone else have...
Sorry I did not see this earlier - I somehow did not receive any notification. I am satisfied with this PR, but I think @jloizu should also give his review.
> There is some commonality between the high-level MHD code integration that I have in #508 and here. > > Could you review that PR, and align with it? >...
Thanks @mishapadidar. I fixed the typo, and I think it's ready to go.