Eitan Joffe

Results 48 comments of Eitan Joffe

Hi Itai, Glad you like it! We are all using it non stop at Inigo. The version is currently set by the build tool (go releaser) through link flags. I...

You should be able to remove the github update call to test out your theory. This call is there to update the stack part of the pr message body but...

pro tip: If you have goreleaser installed, you can build the project using `make bin` I alias my dev built spr so I can easily test it: `alias spr='/Users/eitan/Code/spr/dist/spr_darwin_amd64/git-spr'`

I tried this approach initially, the issue I remember facing with this was that github actions for the next pr up the stack had to rerun after the bottom pr...

If this work well, I am all for adding this as another merge option to spr. One more thing to watch out for is a race between github rebasing the...

Currently pull requests a keyed by a tuple of (username, local branch, commit-id). Technically the commit-id is unique and so we could key by just that, and I think in...

This requires more thought on how to do it right, I'm worried about cases of multiple writers to a single commit-id, where there could be cases that one person overwrites...

This sounds cool! I have never used pull requests templates. Can you describe with more detail how you think of integrating spr with this, from the little reading I did,...

@josephschmitt - I think this was fixed, right?

@TheNumberOne - can you paste the error? does it happened only once? or keeps happening?