spr icon indicating copy to clipboard operation
spr copied to clipboard

Broken version (?)

Open Itay-Tsabary-Starkware opened this issue 3 years ago • 1 comments

Hi,

Thanks for creating this tool, super useful!

I am running into an unexpected problem with the version flag:

git spr --debug version
> git rev-parse --show-toplevel
Config : {
  "Repo": {
    "GitHubRepoOwner": <redacted>,
    "GitHubRepoName": <redacted>,
    "GitHubHost": "github.com",
    "RequireChecks": true,
    "RequireApproval": true,
    "GitHubRemote": <redacted>,
    "GitHubBranch": <redacted>,
    "MergeMethod": "merge"
  },
  "User": {
    "ShowPRLink": true,
    "LogGitCommands": true,
    "LogGitHubCalls": true,
    "StatusBitsHeader": true,
    "StatusBitsEmojis": true,
    "CreateDraftPRs": false,
    "PreserveTitleAndBody": false,
    "Stargazer": false,
    "RunCount": 47
  }
}
dev : unknown : dversion

I installed from source on July 21 (i.e., a week ago).

Thanks!

Itay-Tsabary-Starkware avatar Jul 27 '22 11:07 Itay-Tsabary-Starkware

Hi Itai, Glad you like it! We are all using it non stop at Inigo.

The version is currently set by the build tool (go releaser) through link flags. I think if you build it yourself from source you won't get these. If you have goreleaser installed, you can try make bin and I think you should get a valid version.

ejoffe avatar Jul 27 '22 18:07 ejoffe