Emilio Jesús Gallego Arias

@SkySkimmer CI fails with: > ` "message": "Unable to locate library a (while searching for a .vos file)."` I can of course fix the test, but I'm not sure the...

[fixed the CI meanwhile so you can get a green CI upstream]

> The message change is semi-deliberate (it makes the implem simpler and seems correct). > > TBH IDK why we have 2 messages for failing to find a library. Indeed...

Indeed, I wonder if my npm is doing some hardlinking on its own? Just in case `npm --version = 9.6.7`

Nothing weird on that side, `stat` reports entries in path are regular dirs and files.

They have link count larger than 1, I see: ``` find ~ -samefile _build/default/node_modules/@octokit/auth-token/LICENSE /home/egallego/.cache/dune/db/files/v4/dd/dd65cb7fe001574466341c3a0618de18 /home/egallego/tmp/dune-bugs/dune-promote/_build/default/node_modules/@octokit/core/LICENSE /home/egallego/tmp/dune-bugs/dune-promote/_build/default/node_modules/@octokit/auth-token/LICENSE /home/egallego/tmp/dune-bugs/dune-promote/_build/default/node_modules/@octokit/request-error/LICENSE ```

Indeed, symlinks were an obvious suspect, but I can't see any involved here (so far)

I have checked, if the `@` symbol is not in the path, promotion seems to work fine. So it seems related.

I've tracked this to the part of https://github.com/ocaml/dune/commit/b1c339b868e00fd5a1a3e72db90e57b4f3285208 that avoids adding "empty" directories: https://github.com/ocaml/dune/blob/4f86203f77eb7ead7a07286b7728cbf42a386990/src/dune_targets/dune_targets.ml#L246-L248 I am trying to understand what is wrong here.

I can still corrupt the parser state with this (on the other hand, interrupting the initial requires seems to behave much better). I'll try to figure out next week what's...