coq-lsp icon indicating copy to clipboard operation
coq-lsp copied to clipboard

[coq] Adapt to rocq-prover/rocq#20601

Open ejgallego opened this issue 6 months ago • 4 comments
trafficstars

ejgallego avatar May 21 '25 08:05 ejgallego

@SkySkimmer CI fails with:

"message": "Unable to locate library a (while searching for a .vos file)."

I can of course fix the test, but I'm not sure the new message is good, previous one was:

"message": "Cannot find a physical path bound to logical path a."

ejgallego avatar May 21 '25 10:05 ejgallego

[fixed the CI meanwhile so you can get a green CI upstream]

ejgallego avatar May 21 '25 10:05 ejgallego

The message change is semi-deliberate (it makes the implem simpler and seems correct).

TBH IDK why we have 2 messages for failing to find a library.

SkySkimmer avatar May 21 '25 10:05 SkySkimmer

The message change is semi-deliberate (it makes the implem simpler and seems correct).

TBH IDK why we have 2 messages for failing to find a library.

Indeed I think the change is a good one, what I find a bit confusing is the "searching for .vos", not sure this is relevant for users.

CI failures are not important (web is because I need to use the waterproof overlay, as the web version includes waterproof)

ejgallego avatar May 22 '25 12:05 ejgallego

Upstream PR merged, this can be merged

proux01 avatar Jun 07 '25 18:06 proux01

sign the commit (-S option to git commit) to be mergeable

SkySkimmer avatar Jun 07 '25 19:06 SkySkimmer