Elliott Eggleston
Elliott Eggleston
Fixed by #60
This issue is actually pretty important if Amazon wants to benefit from community contributions. Many of us use IDEs which reformat code to keep indentation consistent when we save a...
Ooh, I was just trying to make the code internally consistent without changing too much. I can make a new PR reformatting it to fit PSR-2.
There's a patch available to fix this. @islandskater43 , if you want to merge #60 , I'll get started bringing my report downloading features over from my own fork.
@bmeynell, thanks for the suggestion! Do you find it better than phpcbf? I've used phpcbf for a few things, and found that it sometimes garbles comment text and omits newlines...
Updated my reformat for 3.2.0 - now fixed by #63
Hi @bjguillot , I've taken the 'elseif' clarifications out of my latest version of the PSR/2 fix so it should be easier to review. Is there any chance it could...
@bjguillot , to review this you might want to use the '-w' switch to 'git diff' or 'git log' That switch will ignore all the changes where whitespace is just...
Updated for 3.2.0, conflicts resolved. @bjguillot want to merge this? It looks pretty silly to have those duplicate Psr\Log files in this library.