Eugene Eisenstein

Results 13 comments of Eugene Eisenstein

True what you say. In my current use case I just provide a dummy password. I looked through patool actually and the root problem is 7z, it doesn't seem to...

Apologies for the delay. I'll submit a new PR this week only you let me know that you don't need it anymore.

Agreed, since this one's already approved.

Thanks. I made a new pull request #3865 that has the decorator logic.

Unless I'm misunderstanding something, this is what I see: First of all, in #2989 the test TestNewClassDeclaredInsideInit defined inside tests/unit/runtime/zero/test_zero_dynamic_class.py appears to have a bug. It should test whether model.fc.weight...

This is the change I'm proposing to the test: ```python # Copyright (c) Microsoft Corporation. # SPDX-License-Identifier: Apache-2.0 # DeepSpeed Team import torch from unit.common import DistributedTest import deepspeed class...

The HF accelerate tests fail because deepspeed.initialize calls shutdown_init_context directly. Then it's called again during `__exit__`, causing the counter to go negative. So I made shutdown_init_context also idempotent. This clearly...

Agreed. I can make the engine object an optional argument to the context and have it store the state on the engine object if provided. If not provided it can...

At a high level this looks reasonable to me. I think what would be most helpful here is if I outlined how I'm using DS and what sorts of features...