Eileen comments

Results 62 comments of


                                            Eileen

trafficstars

Fix macos bug deleting too many files

Fixes https://bugs.ruby-lang.org/issues/20495

rspec tests won't after upgrading from rails 7.1.2 to 7.1.3.2: can't modify frozen Array when requiring environment file

> 7.1.3.2 upgraded to 7.1.2 I'm confused. Are you upgrading to 7.1.3.2? Because going from 7.1.3.2 to 7.1.2 is a downgrade, not an upgrade. 7.1.3.2 is a security release which...

Make `autosave` option work with `has_and_belongs_to_many`

@edipofederle we get a lot of PRs, please be patient with reviews and refrain from pinging individuals.

`ActiveRecord::Migration::check_all_pending!` resets connection pool when in use in other threads

I'm not sure what to do here, we need to establish connections to be able to use this for multiple databases. I introduced the temporary connection because there's a future...

Implement getspecial in ZJIT

Ok I think I fixed the things you asked for, happy to make more changes though if I missed anything.

Shrink capa from OBJ_FREEZE for arrays

> We happen to have rb_obj_freeze() exposed to C extensions, which is currently mostly equivalent to OBJ_FREEZE(). Is it something that could be considered to repurpose it instead, leaving OBJ_FREEZE()...

Shrink capa from OBJ_FREEZE for arrays

> What rubs me the wrong way is that this is clearly a change to the public interface, and it's being pushed through without discussion on the tracker and with...

Laying some ground work to remove AR::Base from the modules

Thanks for the PR @kwstannard I don't think we should move these methods, the change feels cosmetic to me. Lots of parts of Active Record are spread across files so...

Laying some ground work to remove AR::Base from the modules

> Based on my research, the primary thing standing in the way of this is that the connection code and the migration code still assume the ActiveRecord::Base class is the...