Pavel Perestoronin

Results 76 comments of Pavel Perestoronin

Hiya! I'm not in favour of silently changing a parameter value, this is usually makes debugging harder. I'd rather go for one of these: - `raise ValueError`, and then user...

Hi David, Looks like it's a kind of a bug. We should've defined this field as an octet string (SMPP specs, 4.8.4.34), however it's defined as an integer: https://github.com/python-smpplib/python-smpplib/blob/master/smpplib/command.py#L782 For...

Aha, so now the request is successfully sent but SMSC didn't like some parameter value. That's better to check with your SMSC provider actually, I can't see what's wrong from...

Looks like we're actually missing the `ussd_service_op` field in our `SubmitSM` and `DeliverySM` definitions. This has to be fixed

Alright, this is even simpler than I thought. USSD support is already in place for `SubmitSM`, but we're missing it for `DeliverySM`. @ron-15 You can try to replicate these two...

Looks like you implemented it correct. But now you have a totally different issue, similar to #2. This is most likely a vendor-specific command code, which is not included in...

@ywshzh Could you make a PR with the changes you made?

@podshumok What's the status of Python 2 support again?

@podshumok Can we check in the pypi.org how much downloads we get from Python 2? I'd frankly vote for just dropping the support for it.

@mbednarski I'd assume so. Feel free to submit a pull request anyway