Pavel Perestoronin

Results 76 comments of Pavel Perestoronin

Oops, somehow I've accidentally missed the message. I'm sorry. Is the question still actual?

I guess this is a vendor-specific code, right @podshumok ?

Hi @tobiasmcnulty, Sorry, didn't have time to respond sooner. Yes, I think you're right that sockets are thread-safe, that actually bothered me in past. So I'm glad you brought the...

You need to use `pdu.data_coding`, it's not always `latin-1`.

Hi @fpalamour, You're correct that `short_message` is GSM7-encoded, so basically what you need is to reverse [`gsm_encode`](https://github.com/python-smpplib/python-smpplib/blob/master/smpplib/gsm.py#L54-L62). But ensure you're checking `pdu.data_coding` in advance, because it may also contain `iso-8859-1`...

> If I manage to find a suitable solution on my own to decode gsm7, would you be interested in a PR ? Sure @fpalamour

It's somewhat difficult to comment on a code outside a proper PR. I'll re-open the issue for it to be visible. Does the code also work fine with multipart messages,...

For now you'd need to implement it, otherwise indeed it doesn't work out of the box. If feasible, you can still use status notifications from SMSc, in another issue you...

> Should I add some checks to make sure it is a int that is in the valid range `0x00000000-0x7FFFFFFF` ? If you're up to, otherwise just merge it as...

I'm okay with either option. One seems less DRY, another is more friendly