eifrah-aws

Results 12 comments of eifrah-aws

@mwarzynski this is great initiative! I had similar discussions with @ranshid but you beat me to it 😄 A general comment: I think that any data collection implemented within Valkey,...

Why not simply using the standard `PATH` environment variable?

@PingXie, thanks for looking into this. In the meanwhile, I will continue adding the missing functionalities that I want to add to `CMake` (e.g. packaging + RDMA). Another approach is...

> I don't like this approach, it just means we have to pay all the cost of both system without getting the benefits of CMAKE. We should either switch or...

> I guess let's finish creating a fully featured CMAKE file and see how much effort it is to maintain? If this PR is accepted, I am willing to maintain...

> Are you suggesting we drop the Makefile or should we support two build systems in parallel? Eventually, I would like replace Make with CMake > It adds complexity and...

> you need to make sure that the change wont break minimum required version @bjosv I believe that this is addressable by using `cmake_minimum_required(VERSION ..)`

> Let us consider the following criteria, if CMAKE over MAKE more advantages, we can commit it: > > CMAKE maintain easily? > CMAKE compile faster? > the bin executed...

> With this CMake line, I have to go read the documentation to understand add_executable call. CMake has an excellent documentation + great search result in Stackoverflow > And if...

> On that line, @madolson / @ranshid mentioned we could check in the generated Makefile to the source and still provide the same experience to devs unfamiliar with the build...