Eric Huss

Results 735 comments of Eric Huss

Oops, I had just copy/pasted from [the code](https://github.com/rust-lang/rust/blob/2c8bbf50db0ef90a33f986ba8fc2e1fe129197ff/src/libsyntax_ext/deriving/mod.rs#L65-L90) and didn't pay attention.

Thanks for the ping! Just to clarify, is this just a variant of [trait-object-safety](https://doc.rust-lang.org/nightly/cargo/reference/semver.html#trait-object-safety)? That section explicitly says "adding an item", but could be extended to be "adding, or changing...

@Centril had the idea of using a template on each attribute which would include a list of places where the attribute is valid (and the Syntax): ---- > **Syntax** >...

Some more validation was added via https://github.com/rust-lang/rust/pull/73461, which can help guide updating the docs on where each attribute can be placed.

More validation is being considered in https://github.com/rust-lang/rust/pull/80920. I noticed that [`no_mangle`](https://github.com/rust-lang/reference/blob/5c76e231130c226491f9f243b3e94b8834cfd242/src/abi.md#the-no_mangle-attribute) says it can go on any item. However, I think it only applies to functions and statics. It also...

Thanks for the report! I vaguely recall discussing this, but don't remember why we skipped it. Looks like it should probably be included, though.

Similar comment as https://github.com/rust-lang/reference/pull/1752#issuecomment-2813956975 about the current status and summary.

I think the original is correct, in that it is trying to illustrate that just a bare `m` works by resolving from the crate root. I can see that it...

@joshlf Just checking if you are still interested in working on this? In general it would be helpful for these kinds of PRs to have a short summary about what...

@rust-lang/types would you be able to review this?