Eric Huss

Results 741 comments of Eric Huss

Thanks, sorry for the delay! I'm not fully confident this won't unearth some issues since there are a lot of subtle interactions (like the RUSTFLAGS thing I mentioned above). However,...

I believe this is still an issue. The `exclude` field is still using `starts_with`.

cc #6745, which is a similar issue. The `exclude` key was added in #3837. There doesn't appear to be any discussion at the time about the format to use. It...

I'm going to close as this is unlikely the direction that we want to go. Using shlex as-is would be a breaking change (for example `a\b` would be interpreted differently)....

Can you clarify, I don't think this is specific to workspaces? That is, if you go to the `src` directory and run `cargo build`, you get the same effect where...

Just wanted to note that we generally wanted to avoid any parsing of RUSTFLAGS. Over the years, we have introduced several alternatives (some documented [here](https://github.com/rust-lang/cargo/issues/3686#issuecomment-1324128725)). Another alternative is to support...

@eth3lbert There is something definitely wrong in the tree output. For example, the `"tokio feature "net"` edge is completely missing. All optional dependencies should have a feature edge to them...

I'm pretty sure this is not the intended behavior for `rustc-cdylib-link-arg`. I would say that it should only be passed when building as a cdylib. This is pretty much the...

I don't know what process the compiler team wants to use, but typically in the past they have been using the [Major Change Proposal](https://forge.rust-lang.org/compiler/mcp.html) process for new flags and such...