Erik Huelsmann

Results 308 comments of Erik Huelsmann

@sbts , what does this gain is? Isn't it a good idea to allow entry of payments directly into the invoice screen, even after posting?

While trying to implement this, I'm running into the problem that "old code" uses date formatting according to the user's selection while Workflow expects a global configuration.

This can be fixed once old code is either removed or has standardized on using iso date format as the internal representation.

This seems to be based on a misunderstanding what a "permalink" is or ought to be. The idea of a Permalink is that you get a link which you can...

The same applies to GL transactions. (But only the AR/AP side of things are a regression...)

I have to think longer about this regression (which is actually not really a regression: before this release, "re-saving" a transaction was simply not practical).

The problem with this issue is that saving a draft invoice/transaction causes it to be deleted from the database (and thus loosing the reference for the file to be attached...

In `old/lib/LedgerSMB/AA.pm`, this is the section which causes this problem: https://github.com/ledgersmb/LedgerSMB/blob/0a5675adfa81eba841eb511be4d8e18812d79fb1/old/lib/LedgerSMB/AA.pm#L282-L316 And while it may be possible to remove the "delete" operation for non-batch-related transactions, `voucher__delete` deletes the `transactions` line...

The work-around here, since you *can* attach after posting a transaction, is to wait for the transaction to be posted (at which point there's no need to saving it again)...

Changing the name of the issue to reflect what's left to be done.