ehmicky

Results 372 comments of ehmicky

I added #23 for continuation of this discussion. Follow up questions are: should we allow converting the following objects? - `Operation.parameters` - [`ResponsesObject`](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.1.md#responsesObject) - [`ResponseObject`](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.1.md#responseObject) - [`components.schemas`](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.1.md#componentsObject)

I do not think this is something what is covered by either OpenAPI nor JSON schema, and in that respect, is beyond the scope of this library.

Please note that while OpenAPI 3 uses [JSON schema 5](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#schema-object), OpenAPI 2 uses [JSON schema 4](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#schema-object). They are so similar that only changing `$schema` url is enough as you say....

Just as a note: JSON schema v4 does allow properties which are not valid JSON schema v4 keywords (such as OpenAPI's `x-*` properties): https://tools.ietf.org/html/draft-zyp-json-schema-04#section-3.2 But it could be useful for...

I think it would still be useful as an opt-in for users that want cleaner JSON schemas.

I have the same problem after upgrading Mongoose to 3.8.25. It also seems to come from the deep copy of the `clonedSchema` object. The returned value somehow does not fit...

If those rules are creating issues for you, we should disable them :+1:

I agree. What about either: - Increasing the number of `max-lines-per-function`? - Disabling `max-lines-per-function` and only relying on `max-statements` (which we already do)?

@ziogas Could you please clarify? I am not sure I understand what you precisely mean. Netlify Functions can now directly be written as `.ts` files, in which case transpiling will...

The README's section about TypeScript is different from this issue. I don't think this can be worked around without submitting a PR to modify the above function in this plugin's...