Elise Hinman
Elise Hinman
Copying comments from previous PR so easier to find for this issue: - discuss automatically updating TADA.MonitoringLocationIdentifier to the new MonitoringLocationIdentifier for the grouping, if user desires to assess the...
This function may not be the best place to make decisions on which site to pick without the ability to see sites on a map. But we could give this...
Definitely something worth evaluating in the data. My hunch is that most of the conflicts with left censored (condition) right-censored (limit type) are user errors, since the right-censored limit types...
I cringe a little but if we change all NA to NONE, it would be represented in the validation tables. Elise Hinman, Ph.D. (she/her) ORISE Participant Water Data Integration Branch...
We could also change all NONEs in the validation table to NA, too. That might be a solid solution.
Ok, got it. Sounds good. Thanks!
TADA_Autoclean converts all NONE to NA in the fraction and speciation columns prior to validation, and the validation table has NONE set to INVALID. This still does not address additional...
I've started my review! I'm hoping to hit the Wednesday deadline still.
I am having the same issue as mentioned here: https://github.com/worldbank/blackmarblepy/issues/96. I'm not sure how to get around it. I tried using my own gdf shape, as well as the example...
Thank you for the opportunity to review! This was my first time reviewing a package for pyOpenSci, and I am VERY excited about this package's capabilities and use cases. I...