Eric Helms

Results 178 comments of Eric Helms

Will be fixed by -- https://github.com/theforeman/forklift/pull/907

@mattiasgiese I think the broader solution might be to make the hostmanager options configurable at the box level similar to how other things like memory/cpu/etc. are. Would that solve your...

> Why bother adding el7 support? The os of the db should have little to no influence on the result of the setup. I already had it written from a...

This is ready for further review, I have added a variety of features to it as well to allow spinning up a database with either md5 or scram-sha-256.

I think https://github.com/theforeman/foreman-ansible-modules/issues/646#issuecomment-608480355 would be good to put against https://github.com/theforeman/foreman-ansible-modules/issues/644 As for this issue, now that we have some roles, I feel like we could add any of these "guidelines"...

There was a discussion, at length, in the original role PR (https://github.com/theforeman/foreman-ansible-modules/pull/1027) around this. In that PR, we avoided this as we landed on introducing a role for syncing rather...

Here are my thoughts on the Katello section. katello: - [x] content_view_components: handled by content_view module [example](https://github.com/theforeman/foreman-ansible-modules/blob/develop/plugins/modules/content_view.py#L122) - [x] content_view_puppet_modules: goes away in Katello 4.0, suggest do not implement -...

Related, and based on some discussion with @jlsherrill , today Pulp communication relies on the the CA being trusted by the system (the whole use of trusted_ca module in the...

This might be leaping ahead, and more of "phase 2" but potentially good for the proposal itself. I do find the various tags useful for large operations. But I also...

> Is there is a reason not to omit `foreman::foreman_service_puma_threads_min` ? If it is omitted, then the module will configure it equal to the maximum by default. > > Arguably,...