Egon Elbre
Egon Elbre
Fixes #9749 Automatically fixed with: ``` gofmt -w -r "fmt.Errorf(s) -> errors.New(s)" . goimports -w . ``` Spanner related changes are in https://github.com/googleapis/google-cloud-go/pull/10736
- chore(spanner): simplify test code with strings.EqualFold - chore(spanner): simplify return of bool result - chore(spanner): simplify slice non-empty checks - chore(spanner): avoid type assertions in switch Updates #9784
- perf(spanner): avoid using fmt.Errorf unnecessarily - perf(spanner): avoid duplicated errors.New in UnmarshalJSON - fix(spanner): error strings should not be capitalized Updates #9749
- fix(spanner): incorrect use of sprintf method - fix(spanner): unnecessary use of fmt.Sprintf Updates #9784
- fix(spanner): add missing error checks to tests - fix(spanner): check error before using client in test - chore(spanner): remove redundant return-s Updates #9784
## Is your feature request related to a problem? Please describe. Currently it's not possible to scan JSON columns into a `[]byte` or `json.RawMessage`. ``` go var result json.RawMesage row...
There's a benefit from splitting the work across multiple spanner binaries -- similarly how we handle CockroachDB. This will make the spanner tests run faster. There already exists an implementation...
https://build.dev.storj.tools/job/storj-gerrit-verify/17546/testReport/junit/storj/io_storj_storagenode_console_consoleapi/TestStorageNodeApi_Cockroach_EstimatedPayout/ ``` storagenode_test.go:138: Error Trace: /var/lib/jenkins/workspace/storj-gerrit-verify/storagenode/console/consoleapi/storagenode_test.go:138 Error: Not equal: expected: &estimatedpayouts.EstimatedPayout{CurrentMonth:estimatedpayouts.PayoutMonthly{EgressBandwidth:4600000000000, EgressBandwidthPayout:9200, EgressRepairAudit:9200000000000, EgressRepairAuditPayout:9200, DiskSpace:0, DiskSpacePayout:0, HeldRate:0, Payout:4600, Held:13800}, PreviousMonth:estimatedpayouts.PayoutMonthly{EgressBandwidth:0, EgressBandwidthPayout:0, EgressRepairAudit:0, EgressRepairAuditPayout:0, DiskSpace:42.1, DiskSpacePayout:0, HeldRate:0, Payout:0, Held:0}, CurrentMonthExpectations:290394} actual...