Egon Elbre

spanner: sessions are not being closed when client is closed

2

I was debugging https://github.com/GoogleCloudPlatform/cloud-spanner-emulator/issues/159 problem and found out that using `spanner.Client` leaves about 100 sessions open per client. This in test environments can lead to a situation where creating 1000...

Tracking issue for https://github.com/googleapis/google-cloud-go/pull/10095 Currently the session client workers outlive the client, which may cause use of closed or released resources. This often can show up as flaky tests. Quite...

The code and examples should use `grpc.WithTransportCredentials(insecure.NewCredentials)`, otherwise people keep copy-pasting the deprecated code and using it in their codebase. There are two parts to these fixes. One is the...

Tracking issue for https://github.com/googleapis/google-cloud-go/pull/9759 Related https://github.com/googleapis/google-cloud-go/issues/9784 Currently there are quite a few tests that have a code along the lines of: ``` for _, test := range testcases { client...

Issue for https://github.com/googleapis/google-cloud-go/pull/9757 Currently it's still using workarounds for Go1.12, which are no longer supported https://github.com/googleapis/google-cloud-go/blob/main/spanner/errors112.go -- that code can be removed.

feat: add static analysis tools

1

Static analysis tools are an easy way to find bugs. Fixes #249

`go vet` indicates there's a mistake related to the code in https://github.com/googleapis/go-sql-spanner/blob/6c5c8cb70166ae0abe0f8b2c764cf1970f8cab96/statement_parser.go#L298 ``` $ go vet ./... # github.com/googleapis/go-sql-spanner # [github.com/googleapis/go-sql-spanner] ./statement_parser.go:298:3: self-assignment of sql to sql ``` This also...

Optimizations for ARM64

3

I ended up needing more performance from ed25519.Verify on ARM64, so here's a bunch of optimizations. Unfortunately, both feSquareGeneric and feMulGeneric still spill to the stack, but it should be...