Egon Elbre

Still happening TestDataRepairUploadLimit https://build.dev.storj.tools/blue/organizations/jenkins/storj-gerrit-verify/detail/storj-gerrit-verify/22763/tests ``` log.go:70: 00:13.532 ERROR storage8.piecestore upload failed {"Piece ID": "KDHZOLIYQV53WCBKG5ZQJFIGLDYN3USKB5UFL2V6Q3PCSUMGVKWQ", "Satellite ID": "1xTwTPLWfiqffa5VbA9c7ZZgkhZuAqdp4aphJ6udVWU2LadQF", "Action": "PUT_REPAIR", "Remote Address": "127.0.0.1:39202", "Size": 5120, "error": "hashstore: put:{key:50cf972d18857bbb082a377304950658f0ddd24a0f6855eabe86de295186aaad offset:5696 log:1 length:5632...

https://build.dev.storj.tools/job/storj-gerrit-verify/22864/testReport/junit/storj/io_storj_satellite_repair/TestDataRepairUploadLimit_jobq_Spanner/ ``` og.go:70: 00:14.579 ERROR storage6.piecestore upload failed {"Piece ID": "5E7B2W5EU3263Z64R5GYDI725C2FZ7ENWJOWL6N2LS52CFIM2UBA", "Satellite ID": "1xTwTPLWfiqffa5VbA9c7ZZgkhZuAqdp4aphJ6udVWU2LadQF", "Action": "PUT_REPAIR", "Remote Address": "127.0.0.1:39124", "Size": 5120, "error": "hashstore: put:{key:e93e1d5ba4a6f5ede7dc8f4d81a3fae8b45cfc8db25d65f9ba5cbba1150cd502 offset:5696 log:1 length:5632 created:20213 (2025-05-05) expires:0...

https://build.dev.storj.tools/blue/organizations/jenkins/storj-gerrit-verify/detail/storj-gerrit-verify/22920/tests ``` log.go:70: 00:15.132 WARN satellite-repairer0.segment-repair Repair to a storage node failed {"Stream ID": "025d95be-5c87-4a36-bfaf-63da37449061", "Position": 0, "Placement": 0, "Node ID": "12ipdyyByXHAfvW2AWANwMRqJ3MML4vHErNyzMLQLjBzkxiLitE", "error": "protocol: expected piece hash; hashstore: put:{key:76ba0bb686ede35109d7cf9e86eac59a9ac09f49c4b83a5d873082eaa2039f46 offset:5696...

Upstream issue https://github.com/googleapis/go-sql-spanner/issues/288 and fix https://github.com/googleapis/go-sql-spanner/pull/290

Feel free to revert or change anything. I added and fixed things based on my best knowledge.

@olavloite can you take a look at this. It mostly makes the codebase clean of go vet and staticcheck errors.

A simple fix could be to check whether the query string contains `THEN RETURN`, and if it does then execute it as a RW transaction. e.g. ``` go var rxThenReturn...

This failure suggests two possible scenarios. A. Background service or goroutine is not properly waited to shut down. e.g. something kicks off goroutine, but there's nothing to wait for it's...

With multiplexed sessions this wouldn't help anymore, because they won't be deleted in spanner emulator https://github.com/GoogleCloudPlatform/cloud-spanner-emulator/blob/master/frontend/collections/session_manager.cc#L117

From these options I would lean towards 1. for now. At first glance it would be possible to refactor the `CreateGetRepairOrderLimits` and pass in the `nodes := service.overlay.GetOnlineNodesForAuditRepair(ctx, nodeIDs)` part...