Egon Elbre

Results 224 comments of Egon Elbre

There's an existing related issue https://github.com/googleapis/google-cloud-go/issues/9784 Most linting tooling works in a module boundary. So if you run `go vet ./...` or `staticcheck ./...` it only verifies the current module,...

I definitely feel the pain as well. Without delving into the backstory of things. We've been working on https://github.com/storj/picobuf in the background to minimize the binary sizes. There are still...

So, removing the descriptors only ended up reducing things by 300kb. I also experimented with using picobuf, which reduced things by 2.5MB compared to the baseline. ``` current.exe 83315712 no-descriptors.exe...

As far as I can tell, we might be hitting a inliner bug, which causes some code to be inlined, which probably shouldn't be. I'll need to dig into that...

After looking at the code, the implementation might be somewhat difficult due to how database/sql works. However, one approach would be. First make `*rows.Next` return `[]byte` instead of `spanner.NullJSON` --...

Seems that this would require https://github.com/golang/go/issues/67546 to be added.

happened here https://build.dev.storj.tools/job/storj-gerrit-verify/20167/testReport/junit/storj/io_storj_satellite_repair/TestDataRepairUploadLimit_Cockroach/ ``` log.go:70: 00:03.888 ERROR storage0.piecestore upload failed {"Piece ID": "E5I7323UR23CPPWSMWHWPWDQD6R3RWRAMOAW3RUMWUPL4SSRDWIA", "Satellite ID": "1xTwTPLWfiqffa5VbA9c7ZZgkhZuAqdp4aphJ6udVWU2LadQF", "Action": "PUT_REPAIR", "Remote Address": "127.0.0.1:44874", "Size": 5120, "error": "hashstore: put:{key:2751fdeb748eb627bed2658f67d8701fa3b8da2063816dc68cb51ebe4a511d90 offset:5696 log:1 length:5632 created:20073...

https://build.dev.storj.tools/job/storj-gerrit-verify/20261/testReport/junit/storj/io_storj_satellite_repair/TestDataRepairUploadLimit_Spanner/ ``` log.go:70: 00:12.019 INFO storage11.piecestore uploaded {"Piece ID": "EWCIMMYL4YW3IFCQNOLHNRP4UB5TFUFN4Y3IBRJNUCPUSIHZZGNA", "Satellite ID": "1xTwTPLWfiqffa5VbA9c7ZZgkhZuAqdp4aphJ6udVWU2LadQF", "Action": "PUT_REPAIR", "Remote Address": "127.0.0.1:34080", "Size": 5120} log.go:70: 00:12.098 INFO satellite-repairer0.segment-repair repaired segment {"Stream ID": "a024a527-5141-4a04-adb7-0cd197f59d7e", "Position":...

Failure on Cockroach https://build.dev.storj.tools/job/storj-gerrit-verify/20869/testReport/junit/storj/io_storj_satellite_repair/TestDataRepairUploadLimit_Cockroach/ ``` log.go:70: 00:03.805 WARN satellite-repairer0.segment-repair Repair to a storage node failed {"Stream ID": "039610eb-c504-464e-b000-d26990e3487c", "Position": 0, "Node ID": "1EctVmtKeymcM83KxTrY59fckUcEZX6toUBEYzWmYyGmQp1L4w", "error": "protocol: expected piece hash; hashstore: put:{key:95ba2f9678ac2859bd151bafc1c6a8ed641f7533d6361647804d15b6ff5ce9f5...

Similar issue in TestDataRepairToDiskSHA256 https://build.dev.storj.tools/job/storj-gerrit-verify/21213/testReport/junit/storj/io_storj_satellite_repair/TestDataRepairPendingObject_Spanner/ ``` "1xTwTPLWfiqffa5VbA9c7ZZgkhZuAqdp4aphJ6udVWU2LadQF", "Action": "GET_REPAIR", "Offset": 0, "Size": 5120, "Remote Address": "127.0.0.1:51570"} log.go:70: 00:08.117 INFO storage13.hashstore hashstore opened successfully {"satellite": "1xTwTPLWfiqffa5VbA9c7ZZgkhZuAqdp4aphJ6udVWU2LadQF", "open_time": "163.89465ms"} log.go:70: 00:08.121 INFO...