egfrank

Results 9 comments of egfrank

Can I claim this issue? I haven't done type annotations before but it seems like based on mypy docs the order of operations would be: - Add mypy to the...

Hi, thanks for the response. I totally agree that `mypy to dev requirements and linting can be done independently from adding type annotations` and in fact I have commits for...

Additionally though, I was reading this blog post http://calpaterson.com/mypy-hints.html and they recommend adding two config options to make mypy *more* strict. They say > check_untyped_defs makes mypy attempt to check...

Okay great I'll make a PR with just the dev changes right now. Do I need to get any permissions to make a PR? I'm currently getting a 403 when...

Sorry this too so long to get back to you! I liked the idea of splitting this up into two PRs, one just for the Dev Dependencies and one for...

Hey is this issue unclaimed? I'd be happy to work on this one if so. Also, it seems like it will involve reading pdfs; has that been done within this...

Hi @pjsier, most of information for these meetings is included in PDFs of the minutes and agenda for each meeting. Are there any other spiders that have downloaded / parsed...

Oh awesome I don't know why I missed that in the codebase! Sweet okay I'll look at PyPDF2 and BytesIO.

I finally looked back at this and opened up a new PR! https://github.com/City-Bureau/city-scrapers/pull/973 Sorry about the delay - once my branch got out of date it was difficult to get...