Misha Efimov
Misha Efimov
One concern with removal of `endpoint-load-metrics` headers/trailers is that this will make it more difficult to observe / debug ORCA reports as downstream filters as well as clients will not...
> As discussed offline, should there be a config knob that determines the value here? Yes, I've added a config knob. PTAL when you have a chance.
> Does this mean you no longer need this in the test? > > https://github.com/envoyproxy/envoy/blob/main/test/extensions/load_balancing_policies/client_side_weighted_round_robin/client_side_weighted_round_robin_lb_test.cc#L97-L99 Yes, this code was never needed. Removed.
> I don't think this is the right approach. The ClientSideWeightedRoundRobin LB policy was designed to do endpoint picking only, not locality picking. gRPC's implementation of that policy does and...
Thanks for your inputs! > Also, this interim solution means that any control plane that needs to support gRPC and Envoy will need to send different configuration to the two...
AFAICT this failure is in `IpVersions/ClientSideWeightedRoundRobinXdsIntegrationTest.TwoClusters` and for some reason doesn't have symbols information: ``` [ RUN ] IpVersions/ClientSideWeightedRoundRobinXdsIntegrationTest.TwoClusters/1 #0 [0x55bb370b7f00] #1 __restore_rt [0x7f5799509420] #2 [0x55bb32b4c1a0] #3 [0x55bb32b4ba1e] #4 [0x55bb32b4cd61]...
@adisuissa WDYT about adding some cluster metrics for ORCA load report processing in `Router::Filter`?