Efi Fogel

Results 76 comments of Efi Fogel

Thanks. These are fixed now. ____ _ ____ _ /_____/_) o /__________ __ // (____ ( ( ( (_/ (_/-(-'_(/ _/ On Thu, 1 Sept 2022 at 00:05, Sebastien Loriot...

I've restated old code (which I deleted by mistake) back into the Conic_x_monotone_arc_2 and marked it as deprecated. Then, I made sure that the demo still compiles and runs well...

ok, I got tired of trying to get the M_PI macro recognized by MSVC. Instead of M_PI I used the more modern `boost::math::constants::pi()`. BW, C++20 offers a similar constant expression....

- I fixed the memory leak. Indeed there was one. Thanks for catching that. - 'Moving' parameters is missing in many places in the package(s) but not here. In this...

While I did fix one warning ("maybe uninitialized") all warnings (including the one I fixed) have to do with the algebraic traits (and not with the conics traits) so they...

Yes, all 3 are expected. The first 2 are there as a start for supporting unbounded conics. The last is, well, complicated, and not published yet. ____ _ ____ _...

One issue was with std::uniform_int_distribution, which I fixed. An issue with hana remains. One option is to replace the hana-based code with dedicated code (that uses SFINAE). As written in...

I'm missing some information, but let me also add some. 1. The "2D Arrangement" package has been revamped as part of a new feature; see Features/Arrangement on surface 2 ....

Absolutely. I've replaced \cal with \mathcal in this new branch I've mentioned (even though they cannot be visually distinguished). Now I see the 2 'S' (so, all info is there)...

1. In general, there is no point enhancing the traits with operations applied to Traits::Curve_2, but it does make sense to add operations that apply to Traits::X_monotone_curve_2. 2. The traits...