Chris Markiewicz

Results 2126 comments of Chris Markiewicz

> Encoding the acquisition time for a measurement tool’s session_id, is RECOMMENDED. This information MUST be stored in the sessions.tsv file at the root level of the dataset in the...

> So I suppose a `sessions.tsv` missing an `acq_time` column would receive a validator warning. This is a warning for regular datasets and an error for additional validation datasets. https://github.com/bids-standard/bids-specification/blob/d8b34f349d5640b4ddf835d42da878c9f5d5e5d9/src/schema/rules/tabular_data/modality_agnostic.yaml#L103-L131...

This sounds like the exact use case for the [`recording-`](https://bids-specification.readthedocs.io/en/stable/glossary.html#recording-entities) entity. Was that considered? At least in the MRI world, two files that differed by `acq-` would not be expected...

> > `recording-` is being currently used to attach `physio` and `stim` data to the main recordings ([link](https://bids-specification.readthedocs.io/en/stable/modality-specific-files/physiological-recordings.html#physiological-recordings)), > > Does that prevent using it in other ways though? I...

Maybe the way to go here is to provide an API to register a space, e.g., ```python ReferenceSpaces.register( 'nativemin', Description='Data resampled to isotropic voxels matching minimum of native voxel sizes',...

Not reading this as REQUIRED language, so if we do this, I think it should be a warning. It doesn't feel extremely helpful, though.

Of the datasets on OpenNeuro, 1119 have files with both a `task` entity and `TaskName` in some JSON sidecar. Of those, 321 do not satisfy the criterion that `entity['task'].lower() ==...

The presence of the field is enforced by the validator, if it's REQUIRED. If this convention is to become a validatable rule, then it needs a schema rule, e.g.: ```yaml...

I would be curious to see a link to code that actually depends on this correspondence, by the way. I understand that there is some EEG code that does depend...

@oesteban Pinging you because this is adapted from your work in BEP38. I'll also make a PR against BEP38 with the relevant changes.