bids-specification icon indicating copy to clipboard operation
bids-specification copied to clipboard

feat(schema): Add meta.templates and allow for composing multiple references

Open effigies opened this issue 5 months ago • 1 comments

This is pulled out of #1714, which needs a way of constructing file rules by composing raw rules with rules adapted for atlas datasets. Since atlas datasets are just derivatives datasets, we can do much of the work in advance.

effigies avatar Jun 18 '25 20:06 effigies

@oesteban Pinging you because this is adapted from your work in BEP38. I'll also make a PR against BEP38 with the relevant changes.

effigies avatar Jun 20 '25 12:06 effigies

Codecov Report

:x: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 82.85%. Comparing base (dd1e5d2) to head (d66c823). :warning: Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
tools/schemacode/src/bidsschematools/schema.py 94.73% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2140      +/-   ##
==========================================
+ Coverage   82.71%   82.85%   +0.13%     
==========================================
  Files          20       20              
  Lines        1608     1621      +13     
==========================================
+ Hits         1330     1343      +13     
  Misses        278      278              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 04 '25 19:08 codecov[bot]

Had to rebase to account for #1440 and #2100. Added documentation on null deletion.

effigies avatar Aug 26 '25 14:08 effigies

This schema induces new errors in the examples. Will need to dig deeper before merging. It would be good to add a CI job to run draft schemas on the examples.

effigies avatar Aug 27 '25 19:08 effigies

Might be easiest to review with https://ignoreorderdiff.com/.

effigies avatar Oct 29 '25 16:10 effigies