Chris Markiewicz
Chris Markiewicz
It looks like the package is getting polluted, so a dirty version is being calculated.
Looks like we inject a token during the build process. https://github.com/nipreps/mriqc/blob/d5b13cb56b6de1493ad91979f0e1e48ebb6708db/.circleci/config.yml#L131-L137 So we probably need to set: ```dockerfile ARG VERSION ENV SETUPTOOLS_SCM_PRETEND_VERSION=$VERSION ``` In the build step: https://github.com/nipreps/mriqc/blob/d5b13cb56b6de1493ad91979f0e1e48ebb6708db/Dockerfile#L31-L37
I agree that we should generally ignore dotfiles.
I don't really understand the rationale for this. JSON files may always be inherited, so why specifically call them out here?
pre-commit.ci run
What's the use case?
Okay, so you have a use case for `AP/PA` MESE scans, but what about all the other groups? Do you get `AP/PA` T1w scans, or is this more in-passing to...
I agree that we shouldn't overload `acq`, and am happy to approve this for MESE. My hesitation is over a lack of use-case for other suffixes.
I would split it. I'm sure that the only reason we kept them together was because they had the same entities at the time, not because of some fundamental sameness....
@oesteban @yarikoptic Are you okay with this more limited proposal?