efarg

Results 8 comments of efarg

I'd like to work on this. ``` impl AsRef for Protocol { fn as_ref(&self) -> &str { std::str::from_utf8(&self.0.as_ref()).unwrap() } } ``` Are we thinking something along these line? I am...

@thomaseizinger yes, I would like to work on this. > I think we should store the protocol as String or &str everywhere to begin with and not convert it. Some...

> Just out of curiosity: was there any particular reason for choosing Bytes over String in the first place? > > [thomaseizinger]: multistream-select predates my involvement in the project so...

Yes, I am very much working on it. But I am a bit lost. So here is the diff of changes made for this issue: https://paste.debian.net/hidden/524606d1/ Upon compilation, E0759 will...

@thomaseizinger what is meant by replacing `ProtocolName` with newtype? newtype is a tuple struct, right? How will a struct replace `ProtocolName`, which is a trait? I have been reading about...

@thomaseizinger sharing some progress. This patch gives 29 errors. I am thinking about how to solve them. https://paste.debian.net/hidden/3c3659e9/ Major problem is with `either.rs`. Also, fn. signature changes like this one...

> I am not sure this makes sense? The point of this change is to remove a layer of abstraction. By virtue, this means we will get more concrete in...